[DRAFT DO NOT REVIEW] Make ObserverHolder thread safe by having a thread local observer member #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 64fe5c2 into c68a770 - view on LGTM.com new alerts:
|
albertogpz
force-pushed
the
query_observer_holder_thread_local
branch
from
64fe5c2 to
2a98a10
Compare
albertogpz
force-pushed
the
query_observer_holder_thread_local
branch
from
2a98a10 to
141e30f
Compare
|
this PR appears to be abandoned, can it be closed? |
onichols-pivotal
requested changes
Feb 5, 2022
6 tasks
I would prefer not to close it yet as it is an alternative approach to #6874 as it is mentioned in the comments. |
onichols-pivotal
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?