GEODE-9478: Fix status --dir to use file controller

[gaussianrecurrence]

• Previously when you only specified --dir option the PID was read from
  the member workDir and the status request was attempted to solved by
  using the attachment API, and after that JMX interface.
  But given only --dir was specified the controller resolving the
  request should be FileProcessController instead.
• Logic has been changed for both servers and locators to always use
  FileProcessConroller whenever only --dir flag is specified.
• Added an UT to verify new code.
• Modified several ITs to verify the new behaviour.
• Deleted the following ITs which no longer apply with the new logic:
  • statusWithEmptyPidFileThrowsIllegalArgumentException
  • statusWithEmptyWorkingDirectoryReturnsNotRespondingWithDetails
  • statusWithStalePidFileReturnsNotResponding

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• Has your PR been rebased against the latest commit within the target branch (typically develop)?

• Is your initial contribution a single, squashed commit?

• Does gradlew build run cleanly?

• Have you written or updated unit tests to verify your changes?

• [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to [email protected].

[kirklund]

Thanks for working on this change! Please give me a day or so to finish reviewing.

[kirklund]

I would remove the @throws IllegalArgumentException javadoc clause on the new constructors of FileProcessController and then go ahead and merge.

[kirklund]

Delete throws since pid is not a parameter on this constructor.

[kirklund]

Delete throws since pid is not a parameter on this constructor.

[gaussianrecurrence]

Thanks for pointing this out. Change done!

[onichols-pivotal]

Consider adding the windows label to this PR then pushing another commit (or an empty commit) to be sure there won't be any OS-specifc surprises.

[gaussianrecurrence]

Consider adding the windows label to this PR then pushing another commit (or an empty commit) to be sure there won't be any OS-specifc surprises.

Thanks for mentioning that. I tend to forget about Windows :)

[onichols-pivotal]

this PR appears to be abandoned (although I'm not sure why), should it be merged or closed?

[gaussianrecurrence]

this PR appears to be abandoned (although I'm not sure why), should it be merged or closed?

I haven't look into this for a long time. I'd like to get this merged if possible, so I'll work on the merge conflicts and try to get the missing reviews, if any others are needed