feat: Optimizing Sorting Performance via Radix Sort Algorithm #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Loognqiang
reviewed
Aug 18, 2025
| if (type.isPrimitive()) { | ||
| String sqlTypeName = convertToSqlTypeName(type); | ||
| SqlTypeName typeName = SqlTypeName.valueOf(sqlTypeName); | ||
| SqlTypeName typeName = Types.getType(type.getTypeClass()) == Types.BINARY_STRING ? |
There was a problem hiding this comment.
Check Style failed, operatorWrap: '?' should be on a new line.
yaozhongq
reviewed
Sep 10, 2025
| } | ||
| } | ||
| } | ||
| return true; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @Override | ||
| public Iterable<Row> finish() { | ||
| List<Row> sortedRows = new ArrayList<>(allRows); | ||
| sortedRows.sort(topNRowComparator); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| import org.apache.geaflow.common.binary.BinaryString; | ||
| import org.apache.geaflow.dsl.common.data.Row; | ||
|
|
||
| public class MultiFieldRadixSort { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Please add design reports and performance tests. |
|
@yaozhongq Design reports and performance tests are placed in Ralated Issue: #591 |
ftljk
force-pushed
the
feature/radix-sort
branch
from
cb9bab3 to
9e8d9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request introduces an radix sorting algorithm implementation tailored for integers and short strings.
Ralated Issue: #591
How was this PR tested?