Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): Improve error message on architecture not using little-endian format #1918

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Oct 30, 2024

What does this PR do?

previously there was this kind of error stacktrace:

Caused by: java.lang.IllegalArgumentException: false
	at org.apache.fury.util.Preconditions.checkArgument(Preconditions.java:52)
	at org.apache.fury.Fury.deserialize(Fury.java:765)
	at org.apache.fury.Fury.deserialize(Fury.java:815)
	at org.apache.fury.Fury.deserialize(Fury.java:808)
	at org.apache.camel.component.fury.FuryDataFormat.unmarshal(FuryDataFormat.java:79)

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@apupier apupier requested a review from chaokunyang as a code owner October 30, 2024 16:39
@chaokunyang
Copy link
Collaborator

Hi @apupier , thanks for your contribution. The code lint failed, could you execute mvn spotless:apply to format code?

little-endian format

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier force-pushed the improveErrorMessageForPreconditionsOnLittleEndian branch from c6a3bc2 to c3f1c76 Compare October 30, 2024 17:20
@chaokunyang chaokunyang merged commit 0201ade into apache:main Oct 30, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants