Flink Intergration of Aggregation Merge Engine #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchong
reviewed
Jan 11, 2026
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Thanks @platinumhamburg , this looks good in general. I only left some minor comments.
...luss-flink-common/src/test/java/org/apache/fluss/flink/utils/FlinkAggFunctionParserTest.java
Outdated
Show resolved
Hide resolved
...link/fluss-flink-common/src/test/java/org/apache/fluss/flink/utils/FlinkConversionsTest.java
Outdated
Show resolved
Hide resolved
...flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/sink/FlinkTableSinkITCase.java
Outdated
Show resolved
Hide resolved
platinumhamburg
force-pushed
the
flink-aggregation
branch
2 times, most recently
from
7277059 to
4bb3911
Compare
Contributor
Author
|
Hi @wuchong, thanks for your review comments, I've addressed all of them. Please take another look when you have time. |
platinumhamburg
force-pushed
the
flink-aggregation
branch
from
4bb3911 to
a870913
Compare
wuchong
force-pushed
the
flink-aggregation
branch
from
a870913 to
df1b692
Compare
wuchong
approved these changes
Jan 18, 2026
Member
There was a problem hiding this comment.
Thanks @platinumhamburg . I only appended a commit to fix the only comment with a test for this case and rebased the branch.
| for (Map.Entry<String, String> param : aggFunction.getParameters().entrySet()) { | ||
| String paramKey = | ||
| AGG_PREFIX + columnName + AGG_SUFFIX + PARAMS_SUFFIX + "." + param.getKey(); | ||
| String paramKey = AGG_PREFIX + columnName + "." + funcName + "." + param.getKey(); |
Member
There was a problem hiding this comment.
The function name value might be in uppercase, so we should convert it to lowercase to ensure the option key is always in lowercase.
Member
|
I will merge it once the CI is passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2244
Brief change log
Tests
API and Format
Documentation