Skip to content

Fix flaky ReplicaTest.testRestore #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gautam-aman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix flaky ReplicaTest.testRestore #2303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fde61c
Fix flaky ReplicaTest.testRestore
Gautam-aman Jan 4, 2026
bd42170
Remove redundant exception handling around snapshot task removal
Gautam-aman Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions fluss-server/src/test/java/org/apache/fluss/server/replica/ReplicaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,10 +690,12 @@ void testRestore(@TempDir Path snapshotKvTabletDirPath) throws Exception {

// We have to remove the first scheduled snapshot task since it's for the previous kv tablet
// whose rocksdb has been dropped.

// Remove the stale snapshot task if it exists
scheduledExecutorService.removeNonPeriodicScheduledTask();
// Trigger snapshot with retry to avoid flakiness
triggerSnapshotTaskWithRetry(scheduledExecutorService, 5);

// trigger one snapshot,
scheduledExecutorService.triggerNonPeriodicScheduledTask();
// wait until the snapshot success
kvSnapshotStore.waitUntilSnapshotComplete(tableBucket, 0);

Expand All @@ -717,7 +719,9 @@ void testRestore(@TempDir Path snapshotKvTabletDirPath) throws Exception {
short newSchemaId = 2;
// trigger one snapshot.
scheduledExecutorService.removeNonPeriodicScheduledTask();
scheduledExecutorService.triggerNonPeriodicScheduledTask();

triggerSnapshotTaskWithRetry(scheduledExecutorService, 5);

// wait until the snapshot success
kvSnapshotStore.waitUntilSnapshotComplete(tableBucket, 1);
// write data with old schema
Expand Down