-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-36992][table] Migrate SplitAggregateRule to java #27383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| import scala.collection.JavaConverters; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid this in java classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait this pr merged first c854ee8
...nner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/SplitAggregateRule.java
Outdated
Show resolved
Hide resolved
...nner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/SplitAggregateRule.java
Outdated
Show resolved
Hide resolved
| newAggCalls.stream() | ||
| .forEach( | ||
| newAggCall -> { | ||
| partialAggCallToGroupSetMap.put( | ||
| newAggCall, | ||
| aggInfoToGroupSetMap.get(aggCall)); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| newAggCalls.stream() | |
| .forEach( | |
| newAggCall -> { | |
| partialAggCallToGroupSetMap.put( | |
| newAggCall, | |
| aggInfoToGroupSetMap.get(aggCall)); | |
| }); | |
| newAggCalls | |
| .forEach( | |
| newAggCall -> partialAggCallToGroupSetMap.put( | |
| newAggCall, | |
| aggInfoToGroupSetMap.get(aggCall))); |
What is the purpose of the change
The PR migrates SplitAggregateRule to java
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation