[FLINK-38804][runtime] Ensure channelStateWriter is closed after the inputGates #27375
+164
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Efrat19
force-pushed
the
FLINK-38804-3.3
branch
from
62e89f3 to
2333f28
Compare
Efrat19
force-pushed
the
FLINK-38804-3.3
branch
from
2333f28 to
0469fec
Compare
Efrat19
changed the title
Contributor
Author
|
@flinkbot run azure |
davidradl
reviewed
Jan 7, 2026
|
|
||
| ChannelStateWriter getChannelStateWriter(); | ||
|
|
||
| void setChannelStateWriter(ChannelStateWriter channelStateWriter); |
Contributor
There was a problem hiding this comment.
nit: the pattern seems to be the define the set then the get method.
davidradl
reviewed
Jan 7, 2026
| } | ||
|
|
||
| public void setChannelStateWriter(ChannelStateWriter channelStateWriter) { | ||
| checkState(this.channelStateWriter == null, "Can not set channelStateWriter twice!"); |
Contributor
There was a problem hiding this comment.
Do we know if we can get here with an existing one present - if so can we check for that situation earlier? I am happy with the check to be safe - but wanted to ask this question.
nit: Can not -> Cannot
davidradl
reviewed
Jan 7, 2026
| */ | ||
| private UserCodeClassLoader userCodeClassLoader; | ||
|
|
||
| @Nullable private volatile ChannelStateWriter channelStateWriter; |
Contributor
There was a problem hiding this comment.
I suggest a comment to describe why this needs to be volatile
github-actions
bot
added
the
community-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation