[FLINK-38510][table-planner] Remove targetColumns from the digest generation of SinkReuser #27107
+76
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyuf
force-pushed
the
FLINK-38510
branch
2 times, most recently
from
73ff406 to
8cf78a2
Compare
xiangyuf
changed the title
|
@yunfengzhou-hub @xuyangzhong PTAL when u have time~ |
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
…eration of SinkReuser
|
Thanks for the PR. LGTM |
xuyangzhong
reviewed
Oct 15, 2025
| public void testSinkReuseWithPartialColumns() { | ||
| public void testSinkReuseWithPartialColumnsNotSupportsTargetColumnWriting() { | ||
| StatementSet statementSet = util.tableEnv().createStatementSet(); | ||
| /// sink1 has not implemented the {@link SupportsTargetColumnWriting} sink ability |
There was a problem hiding this comment.
nit use // instead of using ///
| @Test | ||
| public void testSinkReuseWithPartialColumnsAndSupportsTargetColumnWriting() { | ||
| StatementSet statementSet = util.tableEnv().createStatementSet(); | ||
| /// sink2 has implemented the {@link SupportsTargetColumnWriting} sink ability |
| </Resource> | ||
| <Resource name="optimized exec plan"> | ||
| <![CDATA[ | ||
| Sink(table=[default_catalog.default_database.sink1], targetColumns=[[0]], fields=[x, EXPR$1]) |
There was a problem hiding this comment.
The plan is a bit strange with the description targetColumns=[[0]] in Sink.
I think we can either:
- In the PhysicalSink, check whether SupportsTargetColumnWriting is present before printing targetColumns, and avoid printing targetColumns if it's not.
- In the PhysicalSink, reference SupportsTargetColumnWriting when printing targetColumns, regardless of the targetColumns themselves.
- Complete the printing of targetColumns based on https://issues.apache.org/jira/browse/FLINK-37708.
As of now, since targetColumns has not been removed from PhysicalSink, I tend to prefer option 1. What do you think, or do you have any other suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove targetColumns from the digest generation of SinkReuser since it is deprecated now.
Brief change log
Remove the targetColumns from the digest generation of SinkReuser.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation