Skip to content

Conversation

@liuyongvs
Copy link
Contributor

What is the purpose of the change

The PR migrates PruneAggregateCallRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

.boxed()
.sorted(Comparator.reverseOrder())
.forEach(index -> newAggCalls.remove((int) index));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments: newAggCalls.remove((int) index) , we need this int cast here. because it will remove the value instead of removing index when doesn't have int cast

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 6, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs liuyongvs force-pushed the PruneAggregateCallRule branch from c218aaf to 48a4d78 Compare January 8, 2025 12:04
@davidradl
Copy link
Contributor

Reviewed by Chi on 09/01/2025 Need a committer to review

@liuyongvs
Copy link
Contributor Author

hi @snuyanzin will you help review this pr?

@github-actions
Copy link

github-actions bot commented May 6, 2025

This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale label May 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants