Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-29436][build] Upgrade spotless for running on JDK 17 #20911

Merged
merged 5 commits into from
Sep 29, 2022
Merged

[FLINK-29436][build] Upgrade spotless for running on JDK 17 #20911

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1eeebc
[FLINK-29436][build] Upgrade spotless for running on JDK 17
tisonkun Sep 28, 2022
16c03fb
spotless:apply
tisonkun Sep 28, 2022
c2b937c
update config keys
tisonkun Sep 28, 2022
ae445d8
Revert "spotless:apply"
tisonkun Sep 28, 2022
57333f8
upgrade spotless and remove workaround
tisonkun Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ under the License.
<hivemetastore.hadoop.version>2.7.5</hivemetastore.hadoop.version>
<japicmp.referenceVersion>1.15.0</japicmp.referenceVersion>
<japicmp.outputDir>tools/japicmp-output</japicmp.outputDir>
<spotless.version>2.13.0</spotless.version>
<spotless.version>2.27.0</spotless.version>
<spotless.scalafmt.version>3.4.3</spotless.scalafmt.version>
<spotless.delimiter>package</spotless.delimiter>
<spotless.license.header>
Expand Down Expand Up @@ -1018,30 +1018,6 @@ under the License.
</build>
</profile>

<profile>
<id>java17</id>
<activation>
<jdk>[17,)</jdk>
</activation>

<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<configuration>
<!-- Current google format does not run on Java 17.
Don't upgrade it in this profile because it formats code differently.
zentol marked this conversation as resolved.
Show resolved Hide resolved
Re-evaluate once support for Java 8 is dropped. -->
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>

<profile>
<id>java11-target</id>
<build>
Expand Down