Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35743][cdc-runtime] Fix the time zone configuration for temporal functions is not effective #3449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FLINK-35743][cdc-runtime] Fix the time zone configuration for temporal functions is not effective #3449

wants to merge 2 commits into from
+61 −23

Conversation

aiwenmo
Copy link
Contributor

@aiwenmo aiwenmo commented Jul 2, 2024

This closes FLINK-35743.

@aiwenmo
Copy link
Contributor Author

aiwenmo commented Jul 2, 2024

@yuxiqian PTAL

yuxiqian
yuxiqian reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @aiwenmo's quick fix! Just left some minor comments about test cases.

...rc/test/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperatorTest.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could still reproduce testTimestampDiffTransform failure when testing time was set to June 1st 04:00. Seems month and year diff will not be 0 when 8 hours gap crossed month / year boundaries, where the output would be -28800, -480, -8, 0, [0 or -1], [0 or -1].

...rc/test/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperatorTest.java Outdated
TIMESTAMPDIFF_TABLEID,
recordDataGenerator.generate(
new Object[] {
new BinaryStringData("2"), -28800, -480, -8, 0, 0, 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

yuxiqian

This comment was marked as duplicate.

Sign in to view

yuxiqian
yuxiqian approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@yuxiqian yuxiqian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pulled, tested locally and dateFormat works as expected. cc @ruanhang1993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxiqian yuxiqian yuxiqian approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
common runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aiwenmo @yuxiqian