[FLINK-35599][cdc-connector][jdbc-mysql]Flink cdc pipeline sink jdbc mysql #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissycn
changed the title
yuanoOo
reviewed
Jul 1, 2024
| public class MySqlDataSinkFactory implements DataSinkFactory { | ||
| private static final Logger LOG = LoggerFactory.getLogger(MySqlDataSinkFactory.class); | ||
|
|
||
| public static final String IDENTIFIER = "mysql-writer"; |
There was a problem hiding this comment.
I think it should be changed to mysql to be consistent with other sink pipeline connectors.
| String jdbcUrl = MysqlPooledDataSinkFactory.INSTANCE.getJdbcUrl(builder.build()); | ||
| builder.connUrl(jdbcUrl); | ||
| // print configs | ||
| Map<String, String> map = config.toMap(); |
There was a problem hiding this comment.
In my experience, when PASSWORD is empty, a NullPointerException will be thrown.
However, MySQL allows the password to be empty.
| + " jdbc.properties.allowPublicKeyRetrieval: true\n" | ||
| + "\n" | ||
| + "sink:\n" | ||
| + " type: mysql-writer\n" |
|
|
||
| @Override | ||
| public void addColumn(TableId tableId, AddColumnEvent addedColumns) | ||
| throws TableNotExistException, CatalogException { |
There was a problem hiding this comment.
Exception that is never thrown: TableNotExistException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #FLINK-35599