Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix the SPI extension admin-api loading of storage-plugins #4403

Closed
3 tasks done
Pil0tXia opened this issue Aug 26, 2023 · 0 comments · Fixed by #4404 or #4405
Closed
3 tasks done

[Bug] Fix the SPI extension admin-api loading of storage-plugins #4403

Pil0tXia opened this issue Aug 26, 2023 · 0 comments · Fixed by #4404 or #4405
Labels
bug Something isn't working

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Aug 26, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

master

What happened

storage-plugins didn't realize org.apache.eventmesh.api.admin.Admin and caused boot failure.

It is a quick fix, including:

  • mongodb
  • knative
  • pravega
  • pulsar

not including:

  • redis (assigned to @fabian4 )
  • kafka (full admin functions WIP)

How to reproduce

  1. SPI loading fail:

image

image

  1. circular dependency:

image

image

  1. NPE:

image

Progress

image

image

image

Fixing Pravega NPE ...

image

Fixed.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Pil0tXia Pil0tXia added the bug Something isn't working label Aug 26, 2023
@Pil0tXia Pil0tXia mentioned this issue Aug 26, 2023
Merged
@fabian4 fabian4 mentioned this issue Aug 27, 2023
Merged
xwm1992 pushed a commit that referenced this issue Aug 28, 2023
@Pil0tXia
[ISSUE #4403] Fix the SPI extension admin-api loading of storage-plug…
b55e6db 
…ins (#4404)

* fix: remove knative circulate dependency

* feat: realize knative admin-api

* feat: realize mongodb admin-api

* feat: realize pulsar admin-api

* feat: realize pravega admin-api

* fix: deliver a config to client instead of null

* chore: revert startup plugin config
xwm1992 pushed a commit that referenced this issue Aug 29, 2023
@fabian4
[ISSUE #4403] Fix redis admin spi (#4405)
fbbb81d 
* feat: fix redis admin spi.

* feat: fix redis admin spi.

* feat: fix redis admin spi.

* feat: fix redis admin spi.

* feat: fix redis admin spi.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Pil0tXia