Skip to content

Conversation

@CrazyHZM
Copy link
Member

What is the purpose of the change

See #9438 comments
https://logging.apache.org/log4j/2.x/security.html#CVE-2021-45105

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #9443 (02bbc44) into 3.0.5-release (3dac257) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             3.0.5-release    #9443   +/-   ##
================================================
  Coverage            65.17%   65.17%           
- Complexity             342      343    +1     
================================================
  Files                 1203     1203           
  Lines                52009    52009           
  Branches              7768     7768           
================================================
  Hits                 33898    33898           
- Misses               14487    14490    +3     
+ Partials              3624     3621    -3     
Impacted Files Coverage Δ
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 69.15% <0.00%> (-2.81%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.95% <0.00%> (-2.41%) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 80.26% <0.00%> (-1.98%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 65.56% <0.00%> (-1.89%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 66.37% <0.00%> (-1.77%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 70.33% <0.00%> (-0.85%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.56% <0.00%> (+0.34%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 68.75% <0.00%> (+0.96%) ⬆️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 64.25% <0.00%> (+0.96%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dac257...02bbc44. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 74ae5bf into apache:3.0.5-release Dec 20, 2021
@CrazyHZM CrazyHZM deleted the fix/upgrade_log4j2_version branch February 14, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants