Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Lazy annotation #7981

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix: Support Lazy annotation #7981

merged 1 commit into from
Jun 7, 2021

Conversation

pinxiong
Copy link
Member

@pinxiong pinxiong commented Jun 4, 2021

What is the purpose of the change

see #829

Brief changelog

  1. support @lazy
  2. add testcase to check default-lazy-init and lazy-init in XML
  3. add testcase to check Lazy annotation

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj added this to the 2.7.12 milestone Jun 4, 2021
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all LGTM except for the code style issue commented above.

1. support Lazy Annotation for both @DubboService and @DubboReference
2. add testcase to check default-lazy-init and lazy-init in XML
3. add testcase to check Lazy annotation
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #7981 (656ad3b) into master (8deb821) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7981   +/-   ##
=========================================
  Coverage     60.82%   60.83%           
+ Complexity      490      489    -1     
=========================================
  Files          1089     1089           
  Lines         43876    43879    +3     
  Branches       6413     6414    +1     
=========================================
+ Hits          26689    26695    +6     
+ Misses        14219    14218    -1     
+ Partials       2968     2966    -2     
Impacted Files Coverage Δ
.../factory/annotation/ServiceClassPostProcessor.java 83.87% <100.00%> (+0.31%) ⬆️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 86.79% <0.00%> (-5.67%) ⬇️
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 70.53% <0.00%> (-3.58%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 57.14% <0.00%> (-3.58%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 59.70% <0.00%> (-0.98%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.71% <0.00%> (+0.22%) ⬆️
...he/dubbo/registry/multicast/MulticastRegistry.java 70.23% <0.00%> (+0.93%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 73.80% <0.00%> (+1.19%) ⬆️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (+4.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8deb821...656ad3b. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 722839e into apache:master Jun 7, 2021
@pinxiong pinxiong deleted the issue#829 branch June 16, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants