Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7943]Handle illegal characters uniformly #7970

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

haoyann
Copy link
Contributor

@haoyann haoyann commented Jun 3, 2021

What is the purpose of the change

#7943

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #7970 (10d23fc) into master (9f6b536) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7970      +/-   ##
============================================
- Coverage     60.85%   60.84%   -0.01%     
+ Complexity      491      490       -1     
============================================
  Files          1089     1089              
  Lines         43876    43873       -3     
  Branches       6413     6412       -1     
============================================
- Hits          26699    26693       -6     
- Misses        14208    14210       +2     
- Partials       2969     2970       +1     
Impacted Files Coverage Δ
...enter/support/nacos/NacosConfigServiceWrapper.java 0.00% <0.00%> (ø)
...enter/support/nacos/NacosDynamicConfiguration.java 0.00% <0.00%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 77.40% <0.00%> (-1.49%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 59.70% <0.00%> (-0.98%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.30% <0.00%> (-0.94%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 93.02% <0.00%> (+2.32%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (+2.97%) ⬆️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (+4.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6b536...10d23fc. Read the comment docs.

@AlbumenJ AlbumenJ merged commit bfcf003 into apache:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants