-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs are stored using a Set replace with Queue #7956
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7956 +/- ##
============================================
+ Coverage 59.92% 59.97% +0.04%
Complexity 489 489
============================================
Files 1089 1089
Lines 43867 43867
Branches 6410 6410
============================================
+ Hits 26288 26309 +21
+ Misses 14623 14608 -15
+ Partials 2956 2950 -6
Continue to review full report at Codecov.
|
b6da41c
to
bb6c57d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use queue instead of set
It would be better that logs are stored using a Queue.
|
good,i agree with you |
What is the purpose of the change
see more information from #7955
logs are stored using a Set replace with Queue
Checklist