Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs are stored using a Set replace with Queue #7956

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

icankeep
Copy link
Contributor

@icankeep icankeep commented Jun 2, 2021

What is the purpose of the change

see more information from #7955
logs are stored using a Set replace with Queue

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@icankeep icankeep changed the title logs are stored using a Queue replace with Set logs are stored using a Set replace with Queue Jun 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #7956 (b6da41c) into master (41d36a2) will increase coverage by 0.04%.
The diff coverage is 21.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7956      +/-   ##
============================================
+ Coverage     59.92%   59.97%   +0.04%     
  Complexity      489      489              
============================================
  Files          1089     1089              
  Lines         43867    43867              
  Branches       6410     6410              
============================================
+ Hits          26288    26309      +21     
+ Misses        14623    14608      -15     
+ Partials       2956     2950       -6     
Impacted Files Coverage Δ
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 28.35% <21.42%> (ø)
...rg/apache/dubbo/qos/legacy/TraceTelnetHandler.java 29.72% <0.00%> (-2.71%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 57.42% <0.00%> (-1.99%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) ⬇️
...rg/apache/dubbo/qos/legacy/CountTelnetHandler.java 54.65% <0.00%> (-1.17%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.59% <0.00%> (+0.22%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 73.80% <0.00%> (+1.19%) ⬆️
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 80.16% <0.00%> (+2.42%) ⬆️
...ng/transport/dispatcher/all/AllChannelHandler.java 75.86% <0.00%> (+6.89%) ⬆️
...ting/exchange/support/header/HeartbeatHandler.java 90.69% <0.00%> (+6.97%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d36a2...b6da41c. Read the comment docs.

@icankeep
Copy link
Contributor Author

icankeep commented Jun 2, 2021

It seems that the unit tests failed due to this commit #7369

@AlbumenJ

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use queue instead of set

@icankeep
Copy link
Contributor Author

icankeep commented Jun 2, 2021

why use queue instead of set

It would be better that logs are stored using a Queue.

  1. Save in order
  2. AccessLogData does not need to be unique

@xiaoheng1
Copy link
Contributor

why use queue instead of set

It would be better that logs are stored using a Queue.

  1. Save in order
  2. AccessLogData does not need to be unique

good,i agree with you

@AlbumenJ AlbumenJ merged commit 683aed9 into apache:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants