Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the status of forbidden when checking that the registry is a… #7946

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

HelloSmallSnail
Copy link

…vailable

What is the purpose of the change

提供者集群停机,消费者调用过程中需要切换zookeeper时,可能会发生forbidden异常,此提交修复该问题。
请参考issue:#7945

Brief changelog

在RegistryDirectory的isAvailable()方法中,增加对forbidden状态的判断

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, please merge master, and then try again to see if ut can pass

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #7946 (50c0474) into master (ab4ced5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7946      +/-   ##
============================================
- Coverage     60.85%   60.84%   -0.02%     
  Complexity      491      491              
============================================
  Files          1089     1089              
  Lines         43877    43877              
  Branches       6412     6412              
============================================
- Hits          26703    26697       -6     
- Misses        14210    14214       +4     
- Partials       2964     2966       +2     
Impacted Files Coverage Δ
.../dubbo/registry/integration/RegistryDirectory.java 76.17% <100.00%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 57.28% <0.00%> (-2.43%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 69.54% <0.00%> (-1.15%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0.00%> (-1.00%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 70.23% <0.00%> (+0.93%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (+1.44%) ⬆️
...port/identifier/BaseServiceMetadataIdentifier.java 60.71% <0.00%> (+3.57%) ⬆️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 92.30% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4ced5...50c0474. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit e18d4d0 into apache:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants