Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the code that RegistryDirectory.java#destroyUnusedInvokers an… #7902

Merged
merged 2 commits into from
May 31, 2021

Conversation

zhongxiongzeng
Copy link

…d RegistryDirectory.java#toMergeInvokerList

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #7902 (efd84a3) into master (a7ae94d) will increase coverage by 0.09%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7902      +/-   ##
============================================
+ Coverage     60.04%   60.14%   +0.09%     
- Complexity      543      544       +1     
============================================
  Files          1089     1089              
  Lines         43858    43836      -22     
  Branches       6403     6396       -7     
============================================
+ Hits          26336    26364      +28     
+ Misses        14575    14527      -48     
+ Partials       2947     2945       -2     
Impacted Files Coverage Δ
.../dubbo/registry/integration/RegistryDirectory.java 76.17% <55.55%> (-0.02%) ⬇️
.../dubbo/monitor/support/AbstractMonitorFactory.java 80.00% <0.00%> (-3.34%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.14% <0.00%> (-1.49%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 64.87% <0.00%> (-0.62%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.37% <0.00%> (-0.23%) ⬇️
...pache/dubbo/remoting/telnet/codec/TelnetCodec.java 51.23% <0.00%> (+0.61%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) ⬆️
.../exchange/support/header/HeaderExchangeServer.java 66.66% <0.00%> (+1.90%) ⬆️
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 80.16% <0.00%> (+2.42%) ⬆️
.../remoting/transport/netty4/NettyClientHandler.java 86.44% <0.00%> (+3.38%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ae94d...efd84a3. Read the comment docs.

@AlbumenJ AlbumenJ merged commit ad82467 into apache:master May 31, 2021
@zhongxiongzeng zhongxiongzeng deleted the dev/p-2105-code-review branch August 12, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants