Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the code that DubboProtocol.java#getClients #7885

Merged
merged 2 commits into from
May 28, 2021

Conversation

zhongxiongzeng
Copy link

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #7885 (c935fc7) into master (d6d8d25) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7885      +/-   ##
============================================
- Coverage     59.64%   59.63%   -0.01%     
+ Complexity      556      555       -1     
============================================
  Files          1088     1088              
  Lines         43847    43850       +3     
  Branches       6400     6403       +3     
============================================
- Hits          26153    26152       -1     
- Misses        14777    14786       +9     
+ Partials       2917     2912       -5     
Impacted Files Coverage Δ
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 64.87% <100.00%> (-0.62%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-11.12%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (-0.69%) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.61% <0.00%> (-0.40%) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100.00% <0.00%> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 81.59% <0.00%> (+0.22%) ⬆️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.43% <0.00%> (+1.88%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d8d25...c935fc7. Read the comment docs.

Copy link
Member

@BurningCN BurningCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@CrazyHZM CrazyHZM merged commit a21a885 into apache:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants