Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timeout intercept on provider side #7851

Merged
merged 1 commit into from
May 24, 2021

Conversation

goodjava
Copy link
Contributor

@goodjava goodjava commented May 24, 2021

Support timeout intercept on provider side
支持provider根据超时时间进行业务打断

场景就是:业务认为即使是provider ,如果一个 操作如果超时了,最好是打断(释放线程).而不是就打一个超时日志
zzy

vvv2

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #7851 (86a6ae4) into master (ff50f91) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7851   +/-   ##
=========================================
  Coverage     59.42%   59.42%           
+ Complexity      557      556    -1     
=========================================
  Files          1086     1088    +2     
  Lines         43800    43865   +65     
  Branches       6391     6400    +9     
=========================================
+ Hits          26028    26067   +39     
- Misses        14894    14918   +24     
- Partials       2878     2880    +2     
Impacted Files Coverage Δ Complexity Δ
.../transport/dispatcher/all2/AllChannelHandler2.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ting/transport/dispatcher/all2/AllDispatcher2.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 41.50% <0.00%> (-9.44%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 59.40% <0.00%> (-4.96%) 0.00% <0.00%> (ø%)
...n/java/org/apache/dubbo/common/utils/LRUCache.java 82.22% <0.00%> (-3.99%) 0.00% <0.00%> (ø%)
...interceptor/ConsumerContextClusterInterceptor.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/qos/legacy/InvokeTelnetHandler.java 70.67% <0.00%> (-2.20%) 0.00% <0.00%> (ø%)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff50f91...86a6ae4. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 48ac1bf into apache:master May 24, 2021
Copy link
Contributor

@plusmancn plusmancn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllDispatcher2, AllChannelHandler2 have the same problem with it.

@@ -1,4 +1,5 @@
all=org.apache.dubbo.remoting.transport.dispatcher.all.AllDispatcher
all2=org.apache.dubbo.remoting.transport.dispatcher.all2.AllDispatcher2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming "all2" to a significant symbol.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extension will move to dubbo-spi-extension in the next few month. I think we can rename it there.

@xiaomaomaomm
Copy link

这个功能 可以加到2.6版本上吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants