-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support timeout intercept on provider side #7851
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7851 +/- ##
=========================================
Coverage 59.42% 59.42%
+ Complexity 557 556 -1
=========================================
Files 1086 1088 +2
Lines 43800 43865 +65
Branches 6391 6400 +9
=========================================
+ Hits 26028 26067 +39
- Misses 14894 14918 +24
- Partials 2878 2880 +2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AllDispatcher2
, AllChannelHandler2
have the same problem with it.
@@ -1,4 +1,5 @@ | |||
all=org.apache.dubbo.remoting.transport.dispatcher.all.AllDispatcher | |||
all2=org.apache.dubbo.remoting.transport.dispatcher.all2.AllDispatcher2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming "all2" to a significant symbol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extension will move to dubbo-spi-extension in the next few month. I think we can rename it there.
这个功能 可以加到2.6版本上吗? |
Support timeout intercept on provider side
支持provider根据超时时间进行业务打断
场景就是:业务认为即使是provider ,如果一个 操作如果超时了,最好是打断(释放线程).而不是就打一个超时日志