-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new Router class for making requests targeted at specified ip … #7756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7756 +/- ##
============================================
+ Coverage 59.17% 59.47% +0.30%
- Complexity 529 557 +28
============================================
Files 1080 1086 +6
Lines 43650 43780 +130
Branches 6372 6385 +13
============================================
+ Hits 25829 26039 +210
+ Misses 14961 14874 -87
- Partials 2860 2867 +7 Continue to review full report at Codecov.
|
/** | ||
* AddressRouterFactory | ||
*/ | ||
@Activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add some conditions to Activate
annotation, so it can be enabled optionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
be6278a
to
78092fe
Compare
/** | ||
* AddressRouterFactory | ||
*/ | ||
@Activate(value = {"router:address"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be simplified to @Activate(value = AddressRouterFactory.NAME)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
LGTM. |
Add a new Router class for making requests targeted at specified ip and port
有时候调用需要指定ip和port,而且每次可能发生变化,比如测试调用线上指定服务器的provider
这种方式好处是比url里设定更动态一点.每次调用我都可以指定新的,并且provider不用打任何tag