Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7724] Nacos service discovery support service reversion and serviceName maping. #7725

Merged
merged 2 commits into from
May 13, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

Fori-#7724

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #7725 (f9b4815) into master (f29663b) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7725      +/-   ##
============================================
- Coverage     59.18%   59.03%   -0.16%     
+ Complexity      529      528       -1     
============================================
  Files          1076     1076              
  Lines         43540    43479      -61     
  Branches       6363     6327      -36     
============================================
- Hits          25771    25666     -105     
- Misses        14903    14955      +52     
+ Partials       2866     2858       -8     
Impacted Files Coverage Δ Complexity Δ
...ubbo/metadata/store/nacos/NacosMetadataReport.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...vent/listener/ServiceInstancesChangedListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 50.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80.00% <0.00%> (-7.50%) 0.00% <0.00%> (ø%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29663b...f9b4815. Read the comment docs.

Copy link
Member

@BurningCN BurningCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 9461f58 into apache:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants