Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to constants instead of literals #7688

Merged
merged 6 commits into from
May 11, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

Refer to constants instead of literals

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #7688 (0d3c4fe) into master (f29663b) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7688      +/-   ##
============================================
+ Coverage     59.18%   59.20%   +0.01%     
  Complexity      529      529              
============================================
  Files          1076     1076              
  Lines         43540    43540              
  Branches       6363     6363              
============================================
+ Hits          25771    25779       +8     
+ Misses        14903    14900       -3     
+ Partials       2866     2861       -5     
Impacted Files Coverage Δ Complexity Δ
...vent/listener/ServiceInstancesChangedListener.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 96.87% <100.00%> (ø) 0.00 <0.00> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <100.00%> (ø) 0.00 <0.00> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) 14.00% <0.00%> (-1.00%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...apache/dubbo/common/extension/ExtensionLoader.java 79.95% <0.00%> (+0.22%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (+1.48%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (+2.97%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) 9.00% <0.00%> (+1.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 87.17% <0.00%> (+6.83%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29663b...0d3c4fe. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 4fe06ec into apache:master May 11, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants