-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer to constants instead of literals #7688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7688 +/- ##
============================================
+ Coverage 59.18% 59.20% +0.01%
Complexity 529 529
============================================
Files 1076 1076
Lines 43540 43540
Branches 6363 6363
============================================
+ Hits 25771 25779 +8
+ Misses 14903 14900 -3
+ Partials 2866 2861 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Refer to constants instead of literals