Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code in RegistryDirectory #7684

Merged
merged 3 commits into from
May 11, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

The rewritten code is consistent with the parent class and can be removed

@codecov-commenter
Copy link

Codecov Report

Merging #7684 (5ef5e24) into master (0ddc988) will decrease coverage by 0.47%.
The diff coverage is 60.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7684      +/-   ##
============================================
- Coverage     59.17%   58.69%   -0.48%     
+ Complexity      501      492       -9     
============================================
  Files          1079     1076       -3     
  Lines         43331    43504     +173     
  Branches       6318     6340      +22     
============================================
- Hits          25641    25536     -105     
- Misses        14851    15112     +261     
- Partials       2839     2856      +17     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 65.40% <0.00%> (-4.30%) 0.00 <0.00> (ø)
.../dubbo/registry/integration/RegistryDirectory.java 76.92% <ø> (+1.58%) 0.00 <0.00> (ø)
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 77.73% <84.21%> (-2.10%) 0.00 <0.00> (ø)
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.58% <100.00%> (+0.04%) 0.00 <0.00> (ø)
...apache/dubbo/remoting/transport/AbstractCodec.java 79.41% <100.00%> (+4.41%) 0.00 <0.00> (ø)
...e/dubbo/registry/consul/ConsulRegistryFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java 0.00% <0.00%> (-61.67%) 0.00% <0.00%> (-10.00%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0.00% <0.00%> (-60.59%) 0.00% <0.00%> (-31.00%)
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <0.00%> (-57.15%) 0.00% <0.00%> (ø%)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5692210...5ef5e24. Read the comment docs.

@AlbumenJ AlbumenJ merged commit b6904c8 into apache:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants