Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dubbo zookeeper registry failed to re-subscribe #7669

Merged
merged 1 commit into from
May 5, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Dubbo zookeeper registry failed to re-subscribe

see more detail from #7665

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #7669 (29a3808) into master (ed1d357) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7669      +/-   ##
============================================
- Coverage     59.18%   59.17%   -0.01%     
  Complexity      529      529              
============================================
  Files          1076     1076              
  Lines         43458    43417      -41     
  Branches       6353     6320      -33     
============================================
- Hits          25721    25694      -27     
+ Misses        14896    14884      -12     
+ Partials       2841     2839       -2     
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 60.36% <0.00%> (-0.38%) 0.00 <0.00> (ø)
...pache/dubbo/registry/support/FailbackRegistry.java 65.89% <100.00%> (-1.40%) 0.00 <0.00> (ø)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80.00% <0.00%> (-7.50%) 0.00% <0.00%> (ø%)
...moting/transport/netty4/NettyEventLoopFactory.java 30.00% <0.00%> (-6.37%) 0.00% <0.00%> (ø%)
.../threadpool/support/limited/LimitedThreadPool.java 83.33% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
...apache/dubbo/registry/retry/AbstractRetryTask.java 47.22% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
...on/threadpool/support/cached/CachedThreadPool.java 85.71% <0.00%> (-4.29%) 0.00% <0.00%> (ø%)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 84.07% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/qos/legacy/LogTelnetHandler.java 30.30% <0.00%> (-3.04%) 0.00% <0.00%> (ø%)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1d357...29a3808. Read the comment docs.

@AlbumenJ AlbumenJ merged commit b23fd38 into apache:master May 5, 2021
goodjava pushed a commit to WZD-MI/incubator-dubbo that referenced this pull request May 6, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants