Support sending generic requests in JSON format #7637

goodjava · 2021-04-26T10:03:40Z

Invoking a dubbo service via calling from api gateway or running dynamic scripts like groovy by simply passing string values instead of using maps or updating jar files.

像网关和groovy动态脚本这样的调用,可以直接通过传递字符串完成一次rpc调用(不必自己再组装Map之类,或者更新jar包).变的更简单.(golang 夸语言的泛化调用也会大幅度降低难度,毕竟字符串更好产出出来,相较于struct)

horizonzy · 2021-04-27T02:54:04Z

dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java

@@ -90,7 +94,9 @@ public Result invoke(Invoker<?> invoker, Invocation inv) throws RpcException {
                    generic = RpcContext.getContext().getAttachment(GENERIC_KEY);
                }

-                if (StringUtils.isEmpty(generic)
+                if (ProtocolUtils.isGsonGenericSerialization(generic)) {


Code clean: This case should after origin first if judgement.

agree with horizonzy

horizonzy · 2021-04-27T02:54:33Z

dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java

@@ -174,6 +180,14 @@ public Result invoke(Invoker<?> invoker, Invocation inv) throws RpcException {
        return invoker.invoke(inv);
    }

+    private Object[] getArgs(final Object[] args, Type[] types) {
+        Gson gson = new Gson();


transfer to instance variable.

xiaoheng1

I think it is better to catch exceptions when converting json to the corresponding type

horizonzy · 2021-04-27T03:17:17Z

I think it is better to catch exceptions when converting json to the corresponding type

agree, catch JsonSyntaxException expcetion and throw RpcException.

kimmking · 2021-04-27T15:10:40Z

dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java

@@ -90,7 +94,9 @@ public Result invoke(Invoker<?> invoker, Invocation inv) throws RpcException {
                    generic = RpcContext.getContext().getAttachment(GENERIC_KEY);
                }

-                if (StringUtils.isEmpty(generic)
+                if (ProtocolUtils.isGsonGenericSerialization(generic)) {


agree with horizonzy

kimmking · 2021-04-27T15:13:03Z

dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java

+    private Object[] getArgs(final Object[] args, Type[] types) {
+        Gson gson = new Gson();
+        return IntStream.range(0, args.length).mapToObj(i -> {
+            String s = args[i].toString();


variable s is unnecessary

goodjava · 2021-04-28T09:38:01Z

I think it is better to catch exceptions when converting json to the corresponding type

After resolving

org.apache.dubbo.rpc.RpcException: Generic serialization [gson] Json syntax exception thrown when parsing (message:abc type:int) error:java.lang.NumberFormatException: For input string: "abc"

xiaoheng1

LGTM

codecov-commenter · 2021-04-28T10:16:06Z

Codecov Report

Merging #7637 (962416f) into master (cd5bb00) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7637      +/-   ##
============================================
- Coverage     59.26%   59.10%   -0.17%     
  Complexity      529      529              
============================================
  Files          1076     1076              
  Lines         43529    43542      +13     
  Branches       6361     6364       +3     
============================================
- Hits          25796    25734      -62     
- Misses        14879    14935      +56     
- Partials       2854     2873      +19

Impacted Files	Coverage Δ	Complexity Δ
...apache/dubbo/common/constants/CommonConstants.java	`100.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java	`61.53% <0.00%> (-8.03%)`	`0.00 <0.00> (ø)`
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java	`37.70% <0.00%> (-3.37%)`	`0.00 <0.00> (ø)`
...ng/transport/dispatcher/all/AllChannelHandler.java	`75.86% <0.00%> (-20.69%)`	`0.00% <0.00%> (ø%)`
...dubbo/common/status/support/LoadStatusChecker.java	`46.15% <0.00%> (-15.39%)`	`0.00% <0.00%> (ø%)`
...rg/apache/dubbo/remoting/utils/PayloadDropper.java	`76.92% <0.00%> (-15.39%)`	`0.00% <0.00%> (ø%)`
...ng/transport/dispatcher/WrappedChannelHandler.java	`47.82% <0.00%> (-15.22%)`	`0.00% <0.00%> (ø%)`
...bo/config/event/listener/LoggingEventListener.java	`50.00% <0.00%> (-12.50%)`	`0.00% <0.00%> (ø%)`
...dubbo/remoting/exchange/support/DefaultFuture.java	`78.63% <0.00%> (-8.55%)`	`0.00% <0.00%> (ø%)`
...he/dubbo/remoting/transport/netty/NettyHelper.java	`29.03% <0.00%> (-6.46%)`	`2.00% <0.00%> (ø%)`
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd5bb00...962416f. Read the comment docs.

goodjava · 2021-04-28T11:08:48Z

I think it is better to catch exceptions when converting json to the corresponding type

agree, catch JsonSyntaxException expcetion and throw RpcException.

done

AlbumenJ · 2021-04-30T03:18:06Z

Please resolve confilcts

horizonzy reviewed Apr 27, 2021

View reviewed changes

xiaoheng1 reviewed Apr 27, 2021

View reviewed changes

kimmking requested changes Apr 27, 2021

View reviewed changes

goodjava force-pushed the gson_generic branch from cfd6798 to 540bfb0 Compare April 28, 2021 09:46

xiaoheng1 approved these changes Apr 28, 2021

View reviewed changes

goodjava force-pushed the gson_generic branch 3 times, most recently from 74046cd to 72ea841 Compare May 6, 2021 06:23

Support sending generic requests in JSON format

d52181a

goodjava force-pushed the gson_generic branch from 72ea841 to d52181a Compare May 6, 2021 06:26

Merge branch 'master' into gson_generic

962416f

AlbumenJ merged commit a873a1d into apache:master May 19, 2021

AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021

Pick from apache#7637 a873a1d

bfe7417

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support sending generic requests in JSON format #7637

Support sending generic requests in JSON format #7637

goodjava commented Apr 26, 2021

horizonzy Apr 27, 2021

kimmking Apr 27, 2021

goodjava Apr 28, 2021

horizonzy Apr 27, 2021

goodjava Apr 28, 2021

xiaoheng1 left a comment

horizonzy commented Apr 27, 2021

kimmking Apr 27, 2021

kimmking Apr 27, 2021

goodjava Apr 28, 2021

goodjava commented Apr 28, 2021 •

edited

Loading

xiaoheng1 left a comment

codecov-commenter commented Apr 28, 2021 •

edited

Loading

goodjava commented Apr 28, 2021

AlbumenJ commented Apr 30, 2021

Support sending generic requests in JSON format #7637

Support sending generic requests in JSON format #7637

Conversation

goodjava commented Apr 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xiaoheng1 left a comment

Choose a reason for hiding this comment

horizonzy commented Apr 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goodjava commented Apr 28, 2021 • edited Loading

xiaoheng1 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 28, 2021 • edited Loading

Codecov Report

goodjava commented Apr 28, 2021

AlbumenJ commented Apr 30, 2021

goodjava commented Apr 28, 2021 •

edited

Loading

codecov-commenter commented Apr 28, 2021 •

edited

Loading