Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate calling metadataInfo#calAndGetRevision methods #7630

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

BurningCN
Copy link
Member

@BurningCN BurningCN commented Apr 26, 2021

for issue #7631

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #7630 (3611c11) into master (0ddc988) will decrease coverage by 0.19%.
The diff coverage is 60.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7630      +/-   ##
============================================
- Coverage     59.17%   58.97%   -0.20%     
- Complexity      501      529      +28     
============================================
  Files          1079     1076       -3     
  Lines         43331    43442     +111     
  Branches       6318     6346      +28     
============================================
- Hits          25641    25621      -20     
- Misses        14851    14974     +123     
- Partials       2839     2847       +8     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 65.87% <0.00%> (-3.83%) 0.00 <0.00> (ø)
...ient/metadata/store/RemoteMetadataServiceImpl.java 33.33% <ø> (+0.57%) 0.00 <0.00> (ø)
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 80.16% <84.21%> (+0.33%) 0.00 <0.00> (ø)
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.53% <100.00%> (ø) 0.00 <0.00> (ø)
...apache/dubbo/remoting/transport/AbstractCodec.java 79.41% <100.00%> (+4.41%) 0.00 <0.00> (ø)
...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java 0.00% <0.00%> (-61.67%) 0.00% <0.00%> (-10.00%)
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <0.00%> (-57.15%) 0.00% <0.00%> (ø%)
...ntext/event/AwaitingNonWebApplicationListener.java 48.48% <0.00%> (-24.25%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5692210...3611c11. Read the comment docs.

@AlbumenJ AlbumenJ linked an issue Apr 27, 2021 that may be closed by this pull request
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 8279187 into apache:master Apr 27, 2021
goodjava pushed a commit to WZD-MI/incubator-dubbo that referenced this pull request May 6, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate calling metadataInfo#calAndGetRevision methods
3 participants