Optimize code to remove useless objects

[srchen1987]

Optimize code to remove useless objects

update before
public void addAttachments(Map<String, String> attachments) {
if (attachments == null) {
return;
}
if (this.attachments == null) {
this.attachments = new HashMap<String, String>();
}
this.attachments.putAll(attachments);
}

update after
public void addAttachments(Map<String, String> attachments) {
if (attachments == null) {
return;
}
if (this.attachments == null) {
this.attachments = attachments;
}else{
this.attachments.putAll(attachments);
}
}

[horizonzy]

The comment is unnecessary

[horizonzy]

indent problem.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@3e02287). Click here to learn what that means.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #7572   +/-   ##
=========================================
  Coverage          ?   59.07%           
  Complexity        ?      529           
=========================================
  Files             ?     1076           
  Lines             ?    43417           
  Branches          ?     6339           
=========================================
  Hits              ?    25648           
  Misses            ?    14923           
  Partials          ?     2846           

Impacted Files	Coverage Δ	Complexity Δ
...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e02287...6d56b90. Read the comment docs.

[gonwan]

Hi there,

Happened to look through the release notes, but this merge introduced side effects. It assumes the argument attachments is not going to be modified outside the method, which is not always correct. Should revert this.

[horizonzy]

Hi there,

Happened to look through the release notes, but this merge introduced side effects. It assumes the argument attachments is not going to be modified outside the method, which is not always correct. Should revert this.

yep, it's indeed risk.