Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI default name adjustment #7557

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Conversation

BurningCN
Copy link
Member

@BurningCN BurningCN commented Apr 15, 2021

for issue #7558

@codecov-io
Copy link

codecov-io commented Apr 15, 2021

Codecov Report

Merging #7557 (3a5f68e) into master (0ddc988) will decrease coverage by 0.43%.
The diff coverage is 60.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7557      +/-   ##
============================================
- Coverage     59.17%   58.73%   -0.44%     
- Complexity      501      525      +24     
============================================
  Files          1079     1076       -3     
  Lines         43331    43409      +78     
  Branches       6318     6339      +21     
============================================
- Hits          25641    25497     -144     
- Misses        14851    15050     +199     
- Partials       2839     2862      +23     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dubbo/event/DirectEventDispatcher.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...n/java/org/apache/dubbo/event/EventDispatcher.java 66.66% <ø> (ø) 0.00 <0.00> (ø)
...rg/apache/dubbo/event/ParallelEventDispatcher.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 65.40% <0.00%> (-4.30%) 0.00 <0.00> (ø)
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 80.16% <84.21%> (+0.33%) 0.00 <0.00> (ø)
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.53% <100.00%> (ø) 0.00 <0.00> (ø)
...apache/dubbo/remoting/transport/AbstractCodec.java 79.41% <100.00%> (+4.41%) 0.00 <0.00> (ø)
...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java 0.00% <0.00%> (-61.67%) 0.00% <0.00%> (-10.00%)
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <0.00%> (-57.15%) 0.00% <0.00%> (ø%)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5692210...3a5f68e. Read the comment docs.

Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit e4a1718 into apache:master Apr 21, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants