fix incorrect handling of the urlBuilder caused the wrong URL to be generated #7501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix incorrect handling of the URLBuilder caused the wrong URL to be generated
Brief changelog
在appItemToUrls方法中,对services进行遍历的时候,因为复用同一个URLBuilder,没有使用深拷贝,导致所有的值都追加在了一起。
serviceItemToUrls方法中,对apps遍历的时候,也是这个问题。不过因为是追加参数到url,所以后者会覆盖前者,这个并不影响功能,我只是在这个上面和appItemToUrls保持统一。
Verifying this change
下面两张图分别是修改后和修改前的,测试程序为 ConfigParserTest#parseConfiguratorsAppMultiServicesTest
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.