Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect handling of the urlBuilder caused the wrong URL to be generated #7501

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

BurningCN
Copy link
Member

@BurningCN BurningCN commented Apr 2, 2021

What is the purpose of the change

fix incorrect handling of the URLBuilder caused the wrong URL to be generated

Brief changelog

在appItemToUrls方法中,对services进行遍历的时候,因为复用同一个URLBuilder,没有使用深拷贝,导致所有的值都追加在了一起。

serviceItemToUrls方法中,对apps遍历的时候,也是这个问题。不过因为是追加参数到url,所以后者会覆盖前者,这个并不影响功能,我只是在这个上面和appItemToUrls保持统一。

Verifying this change

下面两张图分别是修改后和修改前的,测试程序为 ConfigParserTest#parseConfiguratorsAppMultiServicesTest
image
image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@BurningCN BurningCN changed the title fix incorrect handling of the URLBuilder caused the wrong URL to be generated fix incorrect handling of the urlBuilder caused the wrong URL to be generated Apr 2, 2021
@chickenlj chickenlj added this to the 2.7.11 milestone Apr 2, 2021
@chickenlj
Copy link
Contributor

LGTM

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit aa6d43d into apache:master Apr 3, 2021
@BurningCN BurningCN deleted the fix_url_generated_error branch April 19, 2021 12:07
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants