Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safeConstructor instead of constructor when parsing yaml #7437

Merged
merged 7 commits into from
Mar 26, 2021

Conversation

kevinw66
Copy link
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 24, 2021

Codecov Report

Merging #7437 (c28eb3e) into master (b5c81d8) will increase coverage by 0.35%.
The diff coverage is 67.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7437      +/-   ##
============================================
+ Coverage     58.71%   59.07%   +0.35%     
- Complexity      422      502      +80     
============================================
  Files          1043     1074      +31     
  Lines         42514    43164     +650     
  Branches       6208     6297      +89     
============================================
+ Hits          24962    25499     +537     
- Misses        14769    14827      +58     
- Partials       2783     2838      +55     
Impacted Files Coverage Δ Complexity Δ
...er/condition/config/model/ConditionRuleParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bo/rpc/cluster/router/tag/model/TagRuleParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/apache/dubbo/common/utils/BeanUtils.java 73.46% <73.46%> (ø) 0.00 <0.00> (?)
.../rpc/cluster/configurator/parser/ConfigParser.java 85.45% <100.00%> (-0.39%) 0.00 <0.00> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 26.86% <0.00%> (-52.24%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 53.16% <0.00%> (-37.98%) 0.00% <0.00%> (ø%)
.../cluster/configurator/parser/model/ConfigItem.java 48.00% <0.00%> (-24.00%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 43.47% <0.00%> (-19.57%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c81d8...c28eb3e. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevinw66 kevinw66 requested a review from AlbumenJ March 26, 2021 09:58
@chickenlj
Copy link
Contributor

LGTM.

The implementation can not support all structures but at least it can meet the requirement at present

@chickenlj chickenlj closed this Mar 26, 2021
@chickenlj chickenlj reopened this Mar 26, 2021
@chickenlj chickenlj merged commit 041f8bb into apache:master Mar 26, 2021
@kevinw66 kevinw66 deleted the yaml-safeconstructor branch March 30, 2021 13:28
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants