-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use safeConstructor instead of constructor when parsing yaml #7437
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7437 +/- ##
============================================
+ Coverage 58.71% 59.07% +0.35%
- Complexity 422 502 +80
============================================
Files 1043 1074 +31
Lines 42514 43164 +650
Branches 6208 6297 +89
============================================
+ Hits 24962 25499 +537
- Misses 14769 14827 +58
- Partials 2783 2838 +55 Continue to review full report at Codecov.
|
dubbo-common/src/main/java/org/apache/dubbo/common/utils/BeanUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM. The implementation can not support all structures but at least it can meet the requirement at present |
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.