-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-7375]fix url add repeatedly #7376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
private int parametersHashCode() {
int h = 0;
for (Map.Entry<String, String> next : parameters.entrySet()) {
if (Constants.TIMESTAMP_KEY.equals(next.getKey())) {
continue;
}
h += next.hashCode();
}
return h;
} |
Codecov Report
@@ Coverage Diff @@
## master #7376 +/- ##
============================================
- Coverage 58.72% 58.64% -0.09%
+ Complexity 425 422 -3
============================================
Files 1043 1043
Lines 42471 42512 +41
Branches 6212 6225 +13
============================================
- Hits 24942 24932 -10
- Misses 14748 14791 +43
- Partials 2781 2789 +8 Continue to review full report at Codecov.
|
AlbumenJ
approved these changes
Mar 17, 2021
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 28, 2021
vio-lin
pushed a commit
to vio-lin/incubator-dubbo
that referenced
this pull request
Feb 22, 2023
* fix url add repeatedly * use iterator to traverse parameters map * remove unused import * import static CommonConstants.TIMESTAMP_KEY Co-authored-by: changye <[email protected]> (cherry picked from commit c7cee8d) # Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/URL.java # dubbo-common/src/test/java/org/apache/dubbo/common/URLTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For-#7375