3.0 preview #7372
Merged
3.0 preview #7372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
requested changes
Mar 15, 2021
| private static ConcurrentHashMap<String, MeshAppRuleListener> appRuleListeners = new ConcurrentHashMap<>(); | ||
|
|
||
| public static void subscribeAppRule(String app) { | ||
| // 注册 diamond 的监听 |
| import java.util.Map; | ||
|
|
||
|
|
||
| public class BaseRule { |
There was a problem hiding this comment.
pls override equal and hashcode method
| package org.apache.dubbo.rpc.cluster.router.mesh.rule.destination; | ||
|
|
||
|
|
||
| public class TCPSettings { |
There was a problem hiding this comment.
what is this class used for? without getter and setter method
| package org.apache.dubbo.rpc.cluster.router.mesh.rule.destination; | ||
|
|
||
|
|
||
| public class TcpKeepalive { |
There was a problem hiding this comment.
what is this class used for? without getter and setter method
| public class DubboMethodArg { | ||
| private int index; | ||
| private String type; | ||
| private ListStringMatch str_value; |
|
|
||
|
|
||
| public class DubboMethodMatch { | ||
| private StringMatch name_match; |
| Yaml yaml = new Yaml(); | ||
| DestinationRule destinationRule = yaml.loadAs(this.getClass().getClassLoader().getResourceAsStream("DestinationRuleTest.yaml"), DestinationRule.class); | ||
|
|
||
| System.out.println(destinationRule); |
There was a problem hiding this comment.
System.out.println has no effect in ut
| Yaml yaml = new Yaml(); | ||
| VirtualServiceRule virtualServiceRule = yaml.loadAs(this.getClass().getClassLoader().getResourceAsStream("VirtualServiceTest.yaml"), VirtualServiceRule.class); | ||
|
|
||
| System.out.println(virtualServiceRule); |
There was a problem hiding this comment.
it should be better to change to equal check
AlbumenJ
requested changes
Mar 15, 2021
Codecov Report
@@ Coverage Diff @@
## 3.0-preview #7372 +/- ##
=================================================
+ Coverage 57.13% 57.54% +0.40%
- Complexity 356 357 +1
=================================================
Files 983 1018 +35
Lines 40155 40746 +591
Branches 5999 6087 +88
=================================================
+ Hits 22943 23446 +503
- Misses 14501 14560 +59
- Partials 2711 2740 +29
Continue to review full report at Codecov.
|
chickenlj
pushed a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
to support mesh style route rule