Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7363] Support a way to ignore check some key in parameters. #7371

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

horizonzy
Copy link
Member

What is the purpose of the change

For-#7363.

If someone need ignore check someKey.
Just add param ignoreCheckKeys:secretKey .

    <dubbo:registry id="registry1" address="nacos://127.0.0.1:8848">
        <dubbo:parameter key="username" value="nacos"/>
        <dubbo:parameter key="secretKey" value="++++"/>
        <dubbo:parameter key="ignoreCheckKeys" value="secretKey"/>
    </dubbo:registry>

@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #7371 (5641173) into master (d009d0c) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7371      +/-   ##
============================================
- Coverage     58.72%   58.66%   -0.06%     
+ Complexity      425      424       -1     
============================================
  Files          1043     1043              
  Lines         42471    42476       +5     
  Branches       6212     6213       +1     
============================================
- Hits          24942    24920      -22     
- Misses        14748    14772      +24     
- Partials       2781     2784       +3     
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/config/utils/ConfigValidationUtils.java 71.81% <50.00%> (-0.21%) 0.00 <0.00> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
.../registry/multicast/MulticastServiceDiscovery.java 50.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 62.37% <0.00%> (-4.96%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 84.61% <0.00%> (-3.42%) 0.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 48.21% <0.00%> (-2.39%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 94.23% <0.00%> (-1.93%) 0.00% <0.00%> (ø%)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) 16.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d009d0c...5641173. Read the comment docs.

@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Mar 25, 2021
@AlbumenJ AlbumenJ merged commit 455852e into apache:master Mar 25, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants