Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-#7331] Ready common add check service is start success (#7331) #7370

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

jiangxch
Copy link

What is the purpose of the change

XXXXX

Brief changelog

qos "ready" common add check service status feature.
https://github.com/apache/dubbo/issues/7331

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 14, 2021

Codecov Report

Merging #7370 (1abc9ba) into master (7cf6884) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7370      +/-   ##
============================================
- Coverage     58.74%   58.60%   -0.14%     
+ Complexity      426      424       -2     
============================================
  Files          1043     1043              
  Lines         42481    42501      +20     
  Branches       6217     6220       +3     
============================================
- Hits          24955    24909      -46     
- Misses        14742    14807      +65     
- Partials       2784     2785       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/qos/command/impl/Ready.java 3.33% <0.00%> (-46.67%) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 70.21% <0.00%> (-4.26%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...common/serialize/hessian2/Hessian2ObjectInput.java 92.00% <0.00%> (-3.46%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 84.61% <0.00%> (-3.42%) 0.00% <0.00%> (ø%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf6884...1abc9ba. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you please add some descriptions in dubbo-website after this pr merged?

@jiangxch
Copy link
Author

LGTM. Would you please add some descriptions in dubbo-website after this pr merged?

ok,I would fill commond descriptions after pr

@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Mar 17, 2021
@AlbumenJ AlbumenJ merged commit 12aad84 into apache:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants