Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo3-Triple] Remove rpc context to avoid http2 headers override #7345

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Mar 9, 2021

What is the purpose of the change

Fix overrided RPCContext persudo headers that causes request failure

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #7345 (6e7554f) into 3.0 (8c24a48) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #7345      +/-   ##
============================================
- Coverage     57.46%   57.21%   -0.26%     
+ Complexity      357      356       -1     
============================================
  Files           983      983              
  Lines         40137    40155      +18     
  Branches       5996     5978      -18     
============================================
- Hits          23066    22974      -92     
- Misses        14363    14445      +82     
- Partials       2708     2736      +28     
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/rpc/protocol/tri/AbstractStream.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.50% <0.00%> (-11.97%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c24a48...6e7554f. Read the comment docs.

@guohao guohao merged commit 2e7151e into apache:3.0 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants