-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-7332] Fix QOS Ready command #7333
Conversation
Fix QOS Ready command return OK when DubboBootstrap is not ready
This bug may be caused by this problem. |
Codecov Report
@@ Coverage Diff @@
## master #7333 +/- ##
============================================
+ Coverage 59.06% 59.07% +0.01%
- Complexity 462 464 +2
============================================
Files 1044 1044
Lines 42480 42491 +11
Branches 6229 6231 +2
============================================
+ Hits 25090 25103 +13
+ Misses 14591 14589 -2
Partials 2799 2799 Continue to review full report at Codecov.
|
@nickwongwong hi, thanks for your contribution If we modify the inital state of
|
It may a good way to change the state of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are two ServiceConfig, first success and second failed, the ready
should be true?
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fix QOS Ready command return OK when DubboBootstrap is not ready
What is the purpose of the change
Fix issue: #7332
Brief changelog
M dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
Only change one line, which initializes
ready
asfalse
instead oftrue
.Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.