Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7265 AbstractRegistryFactory#getRegistry and destroyAll methods compete for locks in multiple threads #7273

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

fix AbstractRegistryFactory#getRegistry and destroyAll methods compete for locks in multiple threads

see #7265

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

…thods compete for locks in multiple threads
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

Codecov Report

Merging #7273 (8689123) into master (d0b894d) will decrease coverage by 0.96%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7273      +/-   ##
============================================
- Coverage     59.59%   58.63%   -0.97%     
+ Complexity      476      425      -51     
============================================
  Files          1042     1042              
  Lines         42363    42370       +7     
  Branches       6207     6209       +2     
============================================
- Hits          25247    24843     -404     
- Misses        14293    14736     +443     
+ Partials       2823     2791      -32     
Impacted Files Coverage Δ Complexity Δ
...fig/configcenter/TreePathDynamicConfiguration.java 77.14% <ø> (-2.86%) 0.00 <0.00> (ø)
...ter/support/apollo/ApolloDynamicConfiguration.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...gcenter/support/etcd/EtcdDynamicConfiguration.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ubbo/registry/support/AbstractRegistryFactory.java 81.15% <71.42%> (-4.33%) 0.00 <0.00> (ø)
...java/org/apache/dubbo/remoting/etcd/Constants.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/consul/ConsulRegistryFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...metadata/store/etcd/EtcdMetadataReportFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
.../apache/dubbo/remoting/etcd/jetcd/RetryNTimes.java 0.00% <0.00%> (-75.00%) 0.00% <0.00%> (ø%)
.../dubbo/metadata/store/etcd/EtcdMetadataReport.java 0.00% <0.00%> (-65.79%) 0.00% <0.00%> (-13.00%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0.00% <0.00%> (-60.00%) 0.00% <0.00%> (-31.00%)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b894d...701bd00. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 039317c into apache:master Mar 3, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants