-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parameters from registryUrl to prevent config pollution #7189
Conversation
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/directory/AbstractDirectory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best to fix it based on 2.7.9-release
for easy verification.
We will release it in the next version. |
This bug may affect users who set the |
I think there's no rush with this bugfix. I believe this is a regression of 2.7.8 or a few versions before. Considering that A new round of apache vote would take days to weeks, I think it's better to put it in the next release |
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/directory/StaticDirectory.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #7189 +/- ##
============================================
- Coverage 59.98% 59.96% -0.03%
+ Complexity 289 288 -1
============================================
Files 1004 1004
Lines 40016 40020 +4
Branches 5933 5937 +4
============================================
- Hits 24005 23998 -7
- Misses 13314 13318 +4
- Partials 2697 2704 +7
Continue to review full report at Codecov.
|
What is the purpose of the change
Fix #7188