Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-7178] Fix 'java.io.FileNotFoundException' when 'dump.directory' not exists #7178

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

zenuo
Copy link

@zenuo zenuo commented Feb 7, 2021

What is the purpose of the change

Fix 'java.io.FileNotFoundException' when 'dump.directory' not exists

Brief changelog

Try to create if not exists, if can't be created, use 'user.home' as dump directory.

Verifying this change

Link to issue: #7178

Try to create if not exists, if can't be created, use 'user.home' as dump directory. Fix 'java.io.FileNotFoundException' when 'dump.directory' not exists

Signed-off by: zenuo <[email protected]>
@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #7178 (8377798) into master (d70b151) will decrease coverage by 0.10%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7178      +/-   ##
============================================
- Coverage     60.04%   59.93%   -0.11%     
  Complexity      290      290              
============================================
  Files          1004     1004              
  Lines         40014    40024      +10     
  Branches       5941     5943       +2     
============================================
- Hits          24027    23989      -38     
- Misses        13286    13328      +42     
- Partials       2701     2707       +6     
Impacted Files Coverage Δ Complexity Δ
...mmon/threadpool/support/AbortPolicyWithReport.java 86.00% <63.63%> (-11.50%) 0.00 <0.00> (ø)
...ava/org/apache/dubbo/rpc/cluster/Configurator.java 4.00% <0.00%> (-32.00%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyServerHandler.java 61.36% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
.../dubbo/registry/integration/RegistryDirectory.java 43.28% <0.00%> (-4.03%) 0.00% <0.00%> (ø%)
...e/dubbo/registry/integration/RegistryProtocol.java 53.45% <0.00%> (-2.84%) 0.00% <0.00%> (ø%)
...ubbo/registry/client/ServiceDiscoveryRegistry.java 47.64% <0.00%> (-2.36%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/FailbackRegistry.java 59.81% <0.00%> (-0.94%) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70b151...8377798. Read the comment docs.

@zenuo zenuo changed the title [Dubbo-7177] Fix 'java.io.FileNotFoundException' when 'dump.directory' not exists [Dubbo-7178] Fix 'java.io.FileNotFoundException' when 'dump.directory' not exists Feb 7, 2021
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 1124e64 into apache:master Feb 20, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants