增加DubboBootstrap启动停止事件扩展 #7159
Merged
增加DubboBootstrap启动停止事件扩展 #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
reviewed
Jan 29, 2021
...fig-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrapStartStopListener.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #7159 +/- ##
=========================================
Coverage 59.98% 59.99%
+ Complexity 291 289 -2
=========================================
Files 1001 1004 +3
Lines 39957 39977 +20
Branches 5935 5935
=========================================
+ Hits 23970 23984 +14
- Misses 13288 13291 +3
- Partials 2699 2702 +3 Continue to review full report at Codecov.
|
kylixs
reviewed
Feb 2, 2021
...ava/org/apache/dubbo/config/spring/context/DubboBootstrapStartStopListenerSpringAdapter.java
Show resolved
Hide resolved
| @@ -46,6 +46,7 @@ | |||
| public DubboBootstrapApplicationListener(ApplicationContext applicationContext) { | |||
| super(applicationContext); | |||
| this.dubboBootstrap = DubboBootstrap.getInstance(); | |||
| DubboBootstrapStartStopListenerSpringAdapter.applicationContext = applicationContext; | |||
There was a problem hiding this comment.
Is there a better way to initialize DubboBootstrapStartStopListenerSpringAdapter?
chickenlj
pushed a commit
that referenced
this pull request
Feb 7, 2021
AlbumenJ
added a commit
to AlbumenJ/dubbo
that referenced
this pull request
May 26, 2021
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7159 +/- ##
============================================
- Coverage 59.99% 59.99% -0.01%
+ Complexity 292 289 -3
============================================
Files 1001 1004 +3
Lines 39957 39977 +20
Branches 5935 5935
============================================
+ Hits 23973 23984 +11
- Misses 13287 13291 +4
- Partials 2697 2702 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加 DubboBootstrapStartStopListener 来对外通知 DubboBootstarp 的启动停止回调扩展；
向Spring环境抛出DubboBootstarp 的启动停止事件。
#7150