Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message of create extension failure #7131

Merged

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Jan 25, 2021

What is the purpose of the change

Improve error message of create extension failure, avoid a large number of unrelated extension loading failure errors

Brief changelog

Display related error message by name when create extension is failed.

Verifying this change

No extraneous errors are displayed when loading a non-existent extension.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

@codecov-io
Copy link

Codecov Report

Merging #7131 (17a0c2f) into master (27571a0) will decrease coverage by 0.33%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7131      +/-   ##
============================================
- Coverage     60.28%   59.94%   -0.34%     
+ Complexity      509      506       -3     
============================================
  Files          1028     1028              
  Lines         41531    41488      -43     
  Branches       6038     6009      -29     
============================================
- Hits          25036    24872     -164     
- Misses        13750    13848      +98     
- Partials       2745     2768      +23     
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/common/extension/ExtensionLoader.java 77.85% <82.35%> (+2.06%) 0.00 <0.00> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 0.00% <0.00%> (-33.34%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 70.79% <0.00%> (-17.24%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0.00%> (-13.64%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-12.50%) 0.00% <0.00%> (ø%)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27571a0...17a0c2f. Read the comment docs.

@chickenlj chickenlj merged commit 9bb5d9e into apache:master Feb 22, 2021
@chickenlj chickenlj added this to the 2.7.10 milestone Feb 22, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
@kylixs kylixs deleted the improve-extension-loader-find-exception branch October 23, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants