Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-6967] fix bug: config with registries and registryIds, protocols and protoc… #6968

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

wikiwikiwiki
Copy link

fix #6967
处理registry和protocol配置混乱的问题。

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #6968 (2bf0944) into master (3fc2d10) will decrease coverage by 0.13%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6968      +/-   ##
============================================
- Coverage     59.44%   59.30%   -0.14%     
+ Complexity      511      506       -5     
============================================
  Files          1028     1028              
  Lines         41519    41516       -3     
  Branches       6037     6028       -9     
============================================
- Hits          24679    24623      -56     
- Misses        14104    14146      +42     
- Partials       2736     2747      +11     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 66.66% <ø> (ø) 0.00 <0.00> (ø)
...a/org/apache/dubbo/config/ReferenceConfigBase.java 63.00% <20.00%> (-0.64%) 0.00 <0.00> (ø)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 60.35% <80.00%> (+0.81%) 0.00 <0.00> (ø)
...g/apache/dubbo/config/AbstractInterfaceConfig.java 86.17% <100.00%> (-1.48%) 0.00 <0.00> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-11.85%) 15.00% <0.00%> (-2.00%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
...mmon/serialize/kryo/utils/AbstractKryoFactory.java 75.43% <0.00%> (-3.51%) 0.00% <0.00%> (ø%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...2bf0944. Read the comment docs.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KeRan213539
Copy link

LGTM

@AlbumenJ AlbumenJ added this to the 2.7.10 milestone Feb 8, 2021
@AlbumenJ AlbumenJ merged commit f7c6396 into apache:master Feb 8, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registry和protocol相关配置非常混乱,很多情况下都是错误的
4 participants