-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix OOM issue for Hessian2ObjectInput and Hessian2ObjectOutput #6848
Conversation
Change-Id: I4fce78be15179722fea1fa645495783c60b28573 Signed-off-by: yuandm <[email protected]>
...n-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2ObjectInput.java
Outdated
Show resolved
Hide resolved
...n-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2ObjectInput.java
Outdated
Show resolved
Hide resolved
...-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2ObjectOutput.java
Outdated
Show resolved
Hide resolved
...-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2ObjectOutput.java
Outdated
Show resolved
Hide resolved
Change-Id: Iadf99b0c72b621ef3b038d1324c6626e75dbfc8e Signed-off-by: yuandm <[email protected]>
Change-Id: Ifa733d185b68f10a8fbf10e32d73089a32d0d312 Signed-off-by: yuandm <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6848 +/- ##
============================================
- Coverage 59.15% 59.12% -0.04%
+ Complexity 510 507 -3
============================================
Files 1028 1028
Lines 41534 41541 +7
Branches 6041 6041
============================================
- Hits 24570 24560 -10
- Misses 14194 14201 +7
- Partials 2770 2780 +10 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Change-Id: I4fce78be15179722fea1fa645495783c60b28573
Signed-off-by: yuandm [email protected]
What is the purpose of the change
fix OOM when deserializing data
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.