Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent RpcStatus#begincount int overflow in extreme cases #6801

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

manzhizhen
Copy link

@manzhizhen manzhizhen commented Oct 12, 2020

What is the purpose of the change

Prevent RpcStatus#begincount int overflow in extreme cases
防止极端情况下RpcStatus#beginCount int 溢出

fix #6621

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #6801 into master will increase coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6801      +/-   ##
============================================
+ Coverage     58.87%   59.06%   +0.19%     
+ Complexity      508      506       -2     
============================================
  Files          1025     1028       +3     
  Lines         41341    41522     +181     
  Branches       6014     6039      +25     
============================================
+ Hits          24340    24526     +186     
+ Misses        14249    14218      -31     
- Partials       2752     2778      +26     
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 72.61% <66.66%> (-1.20%) 0.00 <0.00> (ø)
.../annotation/DubboConfigConfigurationRegistrar.java 69.23% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 76.00% <0.00%> (-7.34%) 0.00% <0.00%> (ø%)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...mmon/threadpool/support/AbortPolicyWithReport.java 85.00% <0.00%> (-5.00%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 53.17% <0.00%> (-4.05%) 0.00% <0.00%> (ø%)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0.00%> (-3.75%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a466f4f...a6027f4. Read the comment docs.

@manzhizhen manzhizhen merged commit 05b3e03 into apache:master Oct 13, 2020
chickenlj pushed a commit to chickenlj/incubator-dubbo that referenced this pull request Nov 25, 2020
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RpcStatus中beginCount函数实现的一处疑问
2 participants