-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-Optimization]: polish DubboBootstrap #5996
[Dubbo-Optimization]: polish DubboBootstrap #5996
Conversation
...-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
Outdated
Show resolved
Hide resolved
79ac8be
to
75aeffc
Compare
Codecov Report
@@ Coverage Diff @@
## master #5996 +/- ##
============================================
+ Coverage 58.65% 58.68% +0.03%
Complexity 424 424
============================================
Files 1043 1043
Lines 42473 42471 -2
Branches 6212 6212
============================================
+ Hits 24912 24924 +12
+ Misses 14773 14766 -7
+ Partials 2788 2781 -7 Continue to review full report at Codecov.
|
@tangcent hi, thanks for your contribution pls resolve confilcts with the latest master branch |
75aeffc
to
abb1336
Compare
- use Collections.singletonList instead of Arrays.asList - replace some lambda expressions to method reference
abb1336
to
1340dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
polish DubboBootstrap
Brief changelog
Collections.singletonList
instead ofArrays.asList
Verifying this change
Run test cases.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.