Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-5855] ReferenceConfig(null) is not DESTROYED when FINALIZE #5863

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

lkj41110
Copy link
Contributor

What is the purpose of the change

fix #5855

Verifying this change

delete finalizerGuardian

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #5863 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5863      +/-   ##
============================================
- Coverage     61.24%   61.21%   -0.03%     
+ Complexity      499      497       -2     
============================================
  Files           981      981              
  Lines         39142    39141       -1     
  Branches       5643     5644       +1     
============================================
- Hits          23973    23961      -12     
- Misses        12542    12550       +8     
- Partials       2627     2630       +3     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 68.20% <ø> (-0.80%) 0.00 <0.00> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0.00%> (-1.70%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 50.00% <0.00%> (-1.32%) 16.00% <0.00%> (-1.00%)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 81.75% <0.00%> (-0.96%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.73% <0.00%> (+0.62%) 30.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d1ba7...d56100e. Read the comment docs.

@chickenlj chickenlj merged commit 8e07686 into apache:master Apr 2, 2020
@chickenlj chickenlj added this to the 2.7.7 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WARN]ReferenceConfig(null) is not DESTROYED when FINALIZE
3 participants