-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize code in dubbo-common #5597
Conversation
I have watched the log of ci,but I did not know how to fix this error.If anyone could tell me what should I do ,I would be very grateful. |
Fortunately, he performed correctly in my computer, or you can manually close the pr, reopen the pr, or submit a merge request to reactivate the ci check and try. |
Codecov Report
@@ Coverage Diff @@
## master #5597 +/- ##
============================================
+ Coverage 61.21% 61.24% +0.02%
Complexity 423 423
============================================
Files 922 922
Lines 37498 37489 -9
Branches 5431 5427 -4
============================================
+ Hits 22956 22961 +5
+ Misses 12056 12051 -5
+ Partials 2486 2477 -9
Continue to review full report at Codecov.
|
I have read this article, are you sure new Method[0] is better than new Method[methods.size()]? Maybe you should read it again. |
You can read the following sentences in the conclusion part. @lndj |
in java8,new Method[0] is better than new Method[methods.size()],you can learn about this from the below url:
https://shipilev.net/blog/2016/arrays-wisdom-ancients/